Support threshold in DesktopScreenshotTestRule
#1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
requested changes
Oct 1, 2024
| public static fun getEntries ()Lkotlin/enums/EnumEntries; | ||
| public static fun valueOf (Ljava/lang/String;)Landroidx/compose/ui/test/junit4/ScreenshotResultProto$Status; | ||
| public static fun values ()[Landroidx/compose/ui/test/junit4/ScreenshotResultProto$Status; | ||
| public final class androidx/compose/ui/test/junit4/DesktopScreenshotTestRule_desktopKt { |
There was a problem hiding this comment.
Not for this PR, but we need to move this out of ui-test-juint4 to a private module in the future.
| val SSIMTotal = calculateSSIM(expected, given, width, height) | ||
|
|
||
| val stats = | ||
| "[MSSIM] Required SSIM: $threshold, Actual " + "SSIM: " + "%.3f".format(SSIMTotal) |
There was a problem hiding this comment.
Now we have this exception:
Image mismatch! Comparison stats: '[MSSIM] Required SSIM: 0.99, Actual SSIM: 0.976'
Before the change we had:
java.lang.AssertionError: java.lang.AssertionError: Image mismatch! Expected image compose/ui/ui-desktop/platform/androidx_compose_ui_platform_GraphicsLayerTest_rotationXYZ.png, actual: compose/ui/ui-desktop/platform/androidx_compose_ui_platform_GraphicsLayerTest_rotationXYZ_actual.png. FS location: /home/teamcity/agent/work/8a20760945d0aeba/golden
We need to add paths to files
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
GraphicsLayerTest.scale is successful when i change scaleY:
@Test
fun scale() {
val snapshot = renderComposeScene(width = 40, height = 40) {
Box(
Modifier
.graphicsLayer(
scaleX = 2f,
scaleY = 1.0f,
transformOrigin = TransformOrigin(0f, 0f)
)
.requiredSize(10f.dp, 10f.dp).background(Color.Red)
)
Box(
Modifier
.graphicsLayer(
translationX = 10f,
translationY = 20f,
scaleX = 2f,
scaleY = 0.5f
)
.requiredSize(10f.dp, 10f.dp).background(Color.Blue)
)
}
screenshotRule.assertImageAgainstGolden(snapshot)
}
and set threshold to 1.00.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adoption of approximate image comparison for internal screenshot tests from Android.
Now it reports the percentage of similarity:
and corresponding diff as a separate image:
Fixes CMP-5310