Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Align Compose components semantics with UIKit views accessibility #1719

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Align Compose components semantics with UIKit views accessibility #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a8c8ce
Align Compose components semantics with UIKit views accessibility
ASalavei Nov 20, 2024
72dbae9
Rewrite android code from isScreenReaderFocusable to iOS isAccessibil…
ASalavei Dec 10, 2024
13434f6
Merge branch 'jb-main' into andrei.salavei/accessibility-semantics
ASalavei Dec 11, 2024
5b64139
Revert timeout message
ASalavei Dec 11, 2024
7b2cd43
Fix node visibility issue
ASalavei Dec 11, 2024
6aea624
Make custom text trait constant immutable
ASalavei Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityElement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,18 @@ NS_ASSUME_NONNULL_BEGIN

- (NSString *__nullable)accessibilityValue CMP_ABSTRACT_FUNCTION;

- (__nullable id<UITextInput>)accessibilityTextInputResponder CMP_ABSTRACT_FUNCTION;

- (CGRect)accessibilityFrame CMP_ABSTRACT_FUNCTION;

- (BOOL)isAccessibilityElement CMP_ABSTRACT_FUNCTION;

- (BOOL)accessibilityActivate CMP_ABSTRACT_FUNCTION;

- (void)accessibilityIncrement CMP_ABSTRACT_FUNCTION;

- (void)accessibilityDecrement CMP_ABSTRACT_FUNCTION;

// Private SDK method. Calls when the item is swipe-to-focused in VoiceOver.
- (BOOL)accessibilityScrollToVisible;

Expand Down
12 changes: 12 additions & 0 deletions compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityElement.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ - (NSString *__nullable)accessibilityLabel {
CMP_ABSTRACT_FUNCTION_CALLED
}

- (__nullable id<UITextInput>)accessibilityTextInputResponder {
CMP_ABSTRACT_FUNCTION_CALLED
}

- (NSString *__nullable)accessibilityValue {
CMP_ABSTRACT_FUNCTION_CALLED
}
Expand All @@ -96,6 +100,14 @@ - (BOOL)accessibilityActivate {
CMP_ABSTRACT_FUNCTION_CALLED
}

- (void)accessibilityIncrement {
CMP_ABSTRACT_FUNCTION_CALLED
}

- (void)accessibilityDecrement {
CMP_ABSTRACT_FUNCTION_CALLED
}

- (BOOL)accessibilityScroll:(UIAccessibilityScrollDirection)direction {
CMP_ABSTRACT_FUNCTION_CALLED
}
Expand Down
Loading