Show read only package files as unchanged #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtmq
requested changes
Aug 16, 2019
rider/src/main/kotlin/com/jetbrains/rider/plugins/unity/explorer/UnityExplorerNode.kt
Show resolved
Hide resolved
xtmq
approved these changes
Aug 17, 2019
Also remove method filter from one test. It didn't apply in previous SDK versions, meaning the test always passed, and it applies now, but our lookup items are not methods, so the filter doesn't apply to them
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the contents of read only packages are highlighted as IGNORED in Unity Explorer, because they're cache in
Library, which is usually ignored in VCS. Highlighting VCS status is irrelevant as they're read only.