Fix registration of tooltip only highlighter for ReSharper #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves part of RSPL-6988
citizenmatt
added
the
resharper-plugin
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUID references in a
.asmdeffile show a tooltip with the name of the referenced assembly definition. ThisINFOlevel highlighter was registered withTextEffect.TEXT, but should have been registered withTextEffect.NONE.If registered with
TEXT, then ReSharper requires non-default values for the highlighter attributes, and throws an exception when trying to use the attribute (e.g. by placing the caret on a GUID reference). If registered with an empty set of attributes, Rider will not pass the details to the front-end and the tooltip is not shown. This change usesNONE, so ReSharper ignores the text attributes, and adds one non-default attribute, so that Rider will still pass the highlighter to the frontend (but because it's set toNONE, it's ignored.Resolves part of RSPL-6988.