Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix RIDER-69350 Add a warning: MenuItem should be applied only to static methods #2266

Merged
merged 12 commits into from
Feb 7, 2022

Conversation

van800
Copy link
Member

@van800 van800 commented Feb 3, 2022

not sure, should I add "Why Re# is suggesting this" wiki page or it is obvious?

@van800 van800 added the WIP Work in progress. Do not merge! label Feb 3, 2022
@van800 van800 added this to the Rider 2022.1 milestone Feb 3, 2022
@van800 van800 self-assigned this Feb 3, 2022
@van800 van800 removed the WIP Work in progress. Do not merge! label Feb 3, 2022
@van800 van800 requested a review from citizenmatt February 3, 2022 13:28
# Conflicts:
#	resharper/resharper-unity/src/Unity.Rider/Integration/CSharp/Feature/Settings/AdditionalFileLayoutSettingsHelper.cs
#	rider/src/main/kotlin/com/jetbrains/rider/plugins/unity/util/UnityUtils.kt
@van800 van800 force-pushed the net221-RIDER-69350 branch from 81f26a0 to d129104 Compare February 7, 2022 11:57
Copy link
Member

@citizenmatt citizenmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the .gold file is out of date, but other than that, LGTM

@van800 van800 requested a review from citizenmatt February 7, 2022 12:52
@van800 van800 merged commit c25b078 into net221 Feb 7, 2022
@van800 van800 deleted the net221-RIDER-69350 branch February 7, 2022 14:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants