Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix RIDER-70574 Unity Log does throttle on CPU due to the long log entries #2270

Merged
merged 2 commits into from
Feb 8, 2022
Merged

fix RIDER-70574 Unity Log does throttle on CPU due to the long log entries #2270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9557d99
fix RIDER-70574 Unity Log does throttle on CPU due to the long log en…
van800 Feb 8, 2022
636fc98
better perf
van800 Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion rider/src/main/kotlin/com/jetbrains/rider/plugins/unity/toolWindow/log/LogPanelItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,10 @@ data class LogPanelItem(val time : Long,
val mode : LogEventMode,
val message : String,
val stackTrace : String,
val count: Int)
val count: Int) {

val shortPresentation: String
get() {
return message.lineSequence().firstOrNull { it.isNotEmpty() } ?: ""
}
}
2 changes: 1 addition & 1 deletion ...ain/kotlin/com/jetbrains/rider/plugins/unity/toolWindow/log/UnityLogPanelEventRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class UnityLogPanelEventRenderer : ColoredListCellRenderer<LogPanelItem>(), List
override fun customizeCellRenderer(list: JList<out LogPanelItem>, event: LogPanelItem?, index: Int, selected: Boolean, hasFocus: Boolean) {
if (event != null) {
icon = RowIcon(event.type.getIcon(), event.mode.getIcon())
val tokens = tokenizer.tokenize(event.message)
val tokens = tokenizer.tokenize(event.shortPresentation)

for (token in tokens) {
if (!token.used) {
Expand Down