Minor fixes #2289
Merged
Minor fixes #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RIDER-75001
Will be called a huge amount of times for very large projects, so make as lightweight as possible
krasnotsvetov
approved these changes
Mar 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues:
.asmdeffiles (RIDER-75001).asmdeffile, by simply copying the leading whitespace of the preceding referenceIsValidforUnityExternalPsiSourceFile. This is called very frequently, and can have a noticeable impact for very large projectsFormerlySerializedAsattribute warning when applied to the backing field of a property