Add attribute target usage annotations #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when it's good to merge, and where to merge to - this isn't required for Rider 2017.2 |
IvanPashchenko
approved these changes
Oct 16, 2017
|
Currently (2.1.3.4269) the severity of this inspection is not exposed in the UI and defaults to Error. We'd like the ability to downgrade this since it's not actually something that will break builds, just an improper use case. |
|
Yep. It's confusing that it's marked as an error when it compiles, although we do sometimes mark things that result in a runtime failure as an error, and this does fit into that category (e.g. a property marked with But we're going to change it to display as redundant code (greyed out), as they can technically be applied, but they won't do anything. See #325. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Unity attributes don't set
AttributeTargets, put they can only realistically be applied to certain targets. This adds the targets in as external annotations - ReSharper treats this as though they were "real" and shows a warning if the attributes are applied to the wrong target type.