Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for assembly definition files #283

Merged
merged 36 commits into from
Jul 3, 2018
Merged

Support for assembly definition files #283

merged 36 commits into from
Jul 3, 2018

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented Nov 18, 2017 •
edited
Loading

Add support for assembly definition files.

  • Add JSON schema validation for .asmdef files
  • Add File Template to create a new "Assembly Definition File"
  • File Template scope for Unity 2017.3+
  • Add duplicate item schema validation for .asmdef files. ReSharper should do this for JSON, but it's not implemented yet. See RSRP-467118. Warns of duplication of platform and reference
  • Validation of correct references tag in JSON. Requires a cache of existing definition files (which might not be included in the project)
  • Code completion of references elements
  • Go to declaration/find usages on references elements
  • Highlight usages
  • Inspection for self-reference + quick fix
  • Inspection for name matching file name + quick fix
  • Validation of circular references
  • Rename reference
  • Rename file when renaming reference
  • Reimplement file type integration so that it only applies to asmdef files, not all JSON files
  • Ensure .asmdef is added to list of files to be added to .csproj. This is true for new projects, but not for existing projects. It looks like there is code to always include it, but it doesn't work.

@citizenmatt
Wire up JSON validation for asmdef files
312c707 
The completion and validation comes from the asmdef schema on
schemastore.org
@citizenmatt
Add asmdef File Template
c982661
@citizenmatt citizenmatt added this to the Rider 2017.3 milestone Nov 18, 2017
@citizenmatt citizenmatt self-assigned this Nov 18, 2017
@citizenmatt citizenmatt mentioned this pull request Mar 14, 2018
Closed
@citizenmatt citizenmatt modified the milestones: Rider 2018.1, Rider 2018.2 Apr 5, 2018
@citizenmatt citizenmatt changed the base branch from master to 182 April 5, 2018 10:44
@citizenmatt citizenmatt changed the base branch from 182 to master April 13, 2018 14:52
@IvanPashchenko IvanPashchenko changed the base branch from master to wave12 May 11, 2018 15:38
@citizenmatt citizenmatt changed the base branch from wave12 to 182 May 15, 2018 12:51
@citizenmatt
Add PSI references to asmdef references
69809dc 
This commit has a lot of infrastructure to make references and declared elements work in a situation where we don't have an IDeclaration. But supports the usual PSI reference features - unresolved error highlighting, go to declaration, find usages and rename, including optionally renaming the file.
@citizenmatt
Add completion for asmdef references
64d4ddb
@citizenmatt
Add context highlighter for asmdef references
1d6d6ad
citizenmatt added 21 commits May 30, 2018 23:21
@citizenmatt
Add error analysis when referencing self
c9a45a2
@citizenmatt
Merge branch '182' into feature/asmdef
58b12be
@citizenmatt
Remove dummy reference
2408bcd 
Explicitly exclude changed item from text occurrences instead
@citizenmatt
Fix tests after merge
eb8fa16
@citizenmatt
Make asmdef file template require at least 2017.3
662dd51
@citizenmatt
Fix lots of tests
d621807
@citizenmatt
Fix non-deterministic test
b1d42d7
@citizenmatt
Add remove self reference quick fix
85e263e
@citizenmatt
Merge branch '182' into feature/asmdef
3999c28
@citizenmatt
Fix errors from merge
7a0ed22
@citizenmatt
Add inspection + quick fix for mismatched .asmdef
47c22a8
@citizenmatt
Move test files to new folder
81329d7
@citizenmatt
Fix broken tests
bfd9143
@citizenmatt
Ensure "asmdef" is added to generated C# projects
0b2ee1d
@citizenmatt
Update for SDK changes
64db291
@citizenmatt
Fix broken tests due to SDK changes
5706ed2
@citizenmatt
Fix exception with non-project files
2dc26c2
@citizenmatt
Add backend features only for .asmdef files
6399de8
@citizenmatt
Merge branch '182' into feature/asmdef
a5c41a5
@citizenmatt
Missed changes from merge
5152f92
@citizenmatt
Show asmdef errors in solution wide analysis
ff33582
@IvanPashchenko IvanPashchenko self-requested a review July 3, 2018 12:33
@IvanPashchenko
Copy link
Collaborator

LGTM

note: I've restarted Travis builds, they were failed due to issues on their side

@citizenmatt citizenmatt merged commit 8f5ee9c into 182 Jul 3, 2018
@citizenmatt citizenmatt deleted the feature/asmdef branch July 3, 2018 21:21
@citizenmatt citizenmatt changed the title [WIP] Support for assembly definition files Support for assembly definition files Jul 3, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@IvanPashchenko IvanPashchenko IvanPashchenko approved these changes

Assignees

@citizenmatt citizenmatt

Labels
enhancement
Projects
None yet
Milestone
Rider 2018.2
Development

Successfully merging this pull request may close these issues.
2 participants
@citizenmatt @IvanPashchenko