Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding initial annotations for UnityEngine and UnityEditor not null items #34

Merged
merged 2 commits into from
May 23, 2016

Conversation

bigbadtrumpet
Copy link
Contributor

I added the items that I know for certainty are not null. Probably could be more added in the future but this gets the most common items that can never be null.

@citizenmatt
Copy link
Member

Looks great, thanks! I'll review properly on Monday - I need to catch up with a number of issues and PRs.

Thanks for submitting!

@@ -0,0 +1,14 @@
<assembly name="UnityEngine">
<member name="P:UnityEngine.Component.transform">
<attribute ctor="M:JetBrains.Annotations.NotNullAttribute.#ctor" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is accurate. The XML docs for Component.transform state:

The Transform attached to this GameObject (null if there is none attached).

@citizenmatt citizenmatt merged commit 2b8f61a into JetBrains:master May 23, 2016
@citizenmatt
Copy link
Member

Thanks for the pull request! I need the annotations to address other issues, so I'm merging the PR as it stands, but I'm not sure about the NotNull attributes that I've commented on above, if you could take a look, please? If you let me know, I can easily edit the two lines.

Thanks!

@bigbadtrumpet
Copy link
Contributor Author

Yea I have posted a question on Unity's forums to ensure that my assumptions are correct. However it is my understanding (despite the confusing documentation) that the things are marked are correct. As soon as I get any information to the contrary I will update it with a new pull request!

@citizenmatt
Copy link
Member

Awesome, thanks. I think I'll comment them out for now, as it goes against the docs. Would be great to get clarification, though.

@citizenmatt citizenmatt added this to the v1.3 milestone Jan 16, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants