Find usages and completion for ShaderLab properties #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything's unresolved for now
The files are duplicated by Visual C++ adding them to a hidden project for "single file intellisense"
| { | ||
| public class ShaderLabDeclaredElementType : DeclaredElementType | ||
| { | ||
| // TODO: Proper icon |
There was a problem hiding this comment.
Do we want some unity-specific icon here?
There was a problem hiding this comment.
Yep. I'll add a request
| } | ||
|
|
||
| if (style.ShowConstantValue) | ||
| { |
There was a problem hiding this comment.
Is this empty code block intentional?
There was a problem hiding this comment.
Not really. I meant to implement it, and forgot :) No-one's using it yet, though. I'll fix it.
|
|
||
| namespace JetBrains.ReSharper.Plugins.Unity.ShaderLab.Psi.Resolve | ||
| { | ||
| // TODO: Terrible name... |
There was a problem hiding this comment.
It can use a sample of the entity it is describing in the comment then :)
Also, WDYT something like IReferenceToVariableReference (doesn't sound good to me too though)?
citizenmatt
changed the title
citizenmatt
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a resolve step for ShaderLab, enabling find usages and highlighting usages of ShaderLab properties.
Note that this only works for usages of properties in ShaderLab blocks, and not for usages of the same property as a parameters to Cg/HLSL programs.
Blend [_Src] [_Dst])