YAML performance fixes #921

citizenmatt · 2018-11-23T11:14:52Z

Addresses major performance issues with large numbers of large YAML files.

Memory usage:

Use text buffers instead of allocating strings for each node in the PSI tree
Use chameleon nodes to skip creating PSI sub-trees for documents that don't need to be examined

Solution load performance:

Don't walk entire PSI tree looking for references in UnityEvent handler cache

Find usages performance:

Don't walk entire PSI tree looking for references in standard YAML reference searcher

Big impact on solution load

SugoiDev · 2018-11-23T18:48:01Z

Could you consider adding #914 as part of this change?

citizenmatt · 2018-11-23T18:49:46Z

Short answer is no. I’ll reply over there with a longer answer when I’m not on my phone :)

citizenmatt · 2018-11-23T18:50:41Z

And it’s not as bad as it sounds!

SugoiDev · 2018-11-23T18:52:44Z

No problem, take your time!

I.e. the syntax tree isn't fully realised until it's requested

There are no YAML specific declared elements, so it's better handled in consumers, e.g. Unity support, which can search for known C# declared elements (methods, classes, etc.)

If the GUID isn't a known word in text, the chameleon might not be opened

If the node being skipped is the last sibling, we never reset to enumerate descendants, and skip a huge chunk of the file. This needs to be fixed in the SDK

korifey · 2018-11-26T13:50:59Z

resharper/resharper-yaml/src/Psi/Parsing/YamlParser.cs

@@ -23,6 +25,19 @@ public IFile ParseFile()
      }
    }

+    public INode ParseRootBlockNode()
+    {
+      using (var lifetimeDefinition = Lifetimes.Define())


use Lifetimes.Using

citizenmatt added 2 commits November 22, 2018 17:10

Reduce string allocations in YAML tokens

26d424d

Improve performance building event handler cache

ddc63f9

Big impact on solution load

citizenmatt added the yaml label Nov 23, 2018

citizenmatt added this to the Rider 2018.3 milestone Nov 23, 2018

citizenmatt self-assigned this Nov 23, 2018

Parse trailing whitespace as part of parent node

5ccaa60

citizenmatt mentioned this pull request Nov 23, 2018

YAML parsing should respect ignored files and folders #914

Open

citizenmatt added 5 commits November 25, 2018 22:48

Parse root block mapping nodes as chameleon nodes

2d33e2e

I.e. the syntax tree isn't fully realised until it's requested

Check before opening chameleons

53aff80

Remove YAML searcher factory

0112291

There are no YAML specific declared elements, so it's better handled in consumers, e.g. Unity support, which can search for known C# declared elements (methods, classes, etc.)

Use YAML GUID to look inside chameleons

e936e9d

If the GUID isn't a known word in text, the chameleon might not be opened

Work around bug in chameleon tree walking

65079ba

If the node being skipped is the last sibling, we never reset to enumerate descendants, and skip a huge chunk of the file. This needs to be fixed in the SDK

citizenmatt changed the title ~~[WIP] YAML performance fixes~~ YAML performance fixes Nov 25, 2018

korifey reviewed Nov 26, 2018

View reviewed changes

Minor update from review

e7ec25f

citizenmatt merged commit 6b0161c into 183 Nov 26, 2018

citizenmatt deleted the feature/yaml-performance branch November 26, 2018 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YAML performance fixes #921

YAML performance fixes #921

citizenmatt commented Nov 23, 2018 •

edited

Loading

SugoiDev commented Nov 23, 2018

citizenmatt commented Nov 23, 2018

citizenmatt commented Nov 23, 2018

SugoiDev commented Nov 23, 2018

korifey Nov 26, 2018

YAML performance fixes #921

YAML performance fixes #921

Conversation

citizenmatt commented Nov 23, 2018 • edited Loading

SugoiDev commented Nov 23, 2018

citizenmatt commented Nov 23, 2018

citizenmatt commented Nov 23, 2018

SugoiDev commented Nov 23, 2018

korifey Nov 26, 2018

Choose a reason for hiding this comment

citizenmatt commented Nov 23, 2018 •

edited

Loading