Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates to cache handling and property event handlers #939

Merged
merged 6 commits into from
Nov 30, 2018

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented Nov 29, 2018

Plus sneaky, unrelated fix to stop the Generate event function dialog selecting all items by default when called from the gutter icon or code code insight marker. See RIDER-22211

@citizenmatt citizenmatt added this to the Rider 2018.3 milestone Nov 29, 2018
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly not. But I was fed up with it in my "unversioned files". Looking at the file, and the options page that seems to drive it, it looks like it's something that should be shared. And since IntelliJ has no sensible scheme for knowing if a file should be committed or not, I flipped a coin and it ended in.

Copy link
Collaborator

@krasnotsvetov krasnotsvetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@citizenmatt citizenmatt merged commit 82b9428 into 183 Nov 30, 2018
@citizenmatt citizenmatt deleted the bugfix/cache-handling branch November 30, 2018 08:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants