Add extra logging for play mode and refresh #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizenmatt
force-pushed
the
feature/playmode-logging
branch
from
00a81da to
e0c15c0
Compare
van800
reviewed
Jan 14, 2019
|
|
||
| syncPlayState(); | ||
|
|
||
| model.Play.Advise(connectionLifetime, play => |
There was a problem hiding this comment.
What is the reason for changing AdviseNotNull to Advise here?
There was a problem hiding this comment.
Because model.Play is an IRdProperty<bool>, so the value can't be null.
public static void AdviseNotNull<T>(this ISink<T> me, Lifetime lifetime, Action<T> handler)
{
me.Advise(lifetime, (Action<T>) (v =>
{
if ((object) v == null)
return;
handler(v);
}));
}
If T is a value type, then it has to have a value, but it's still cast to object (and boxed) to compare against null.
Perhaps @korifey can confirm that this change is ok?
There was a problem hiding this comment.
Approved. Anyway, I guess we should add where clause to this method to suppress boxing.
van800
approved these changes
Jan 14, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a little bit of logging around switching between play/pause mode, as well as during refresh.