Add support for Teamcity running on custom context name #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will it work for a newly downloaded TeamCity (e.g., when a user does not have TeamCity installed and the plugin downloads and unpacks it itself)? |
|
It shouldn't unless we allow the plugin to manipulate webapps. In fact everything my change does it just removing hard coding for the "ROOT" application name. |
|
In this case, please add some diagnostic message when a customized build is used in a non-applicable environment. Detecting missing application directory and failing early with meaningful error message (it should describe what has happened and what a user should do about it) will be good. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.