-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Removed constraints #189
Merged
Merged
Removed constraints #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33fdbc2
to
771df1b
Compare
termoshtt
added a commit
that referenced
this pull request
Dec 24, 2024
… removed constraints (#251) - As removed constraints has been introduced in #189, this PR adds `feasible_unrelaxed` field in `ommx.v1.Solution` and `SampleSet` to represent the `State` is feasible in terms of removed constraints. - `Instance.relax_constraint` and `Instance.restore_constraint` has been exposed in Python SDK
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ommx.v1.RemovedConstraint
messageommx.v1.Constraint
and removed reason, and stored inommx.v1.Instance
andommx.v1.ParametricInstance
.Instance::relax_constraint
to create a relaxed instance, and revert it withInstance::restore_constraint
.removed_reason
and string-string pairremoved_reason_parameters
because these are designed for human-readability rather than API re-usabilityInstance::evaluate
convertsRemovedConstraint
intoEvaluatedConstraint
as usualConstraint
s. These are merged intoommx.v1.Solution
since users would also want to show the breakage of removed constraints with non-removed constraints