Multiselect support, styles independency of project, multifilter support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 22, 2022 21:20
sadhakbj
reviewed
Feb 14, 2022
| emit("input",_selectedList.value) | ||
| } | ||
| const closeItem = ($item:FilterDataList) => { | ||
| //console.log($event.target.checked); |
sadhakbj
reviewed
Feb 14, 2022
| const _list = computed(()=>props.list); | ||
| const _selectedList = ref([] as FilterDataList[]) | ||
| const _enabled = computed(()=>props.enabled || false); | ||
| //const _value = computed(()=>props.value); |
sadhakbj
reviewed
Feb 14, 2022
| CloseIcon, | ||
| }, | ||
| props: { | ||
| format: { type: String,required: false, default:"" }, |
There was a problem hiding this comment.
The page needs to be reformatted eg: space is missing after: type: String
sadhakbj
reviewed
Feb 14, 2022
| //console.log($event.target.checked); | ||
| const item = _list.value.find(d=>d.code === $item.code); | ||
| const indexElementSelected = _selectedList.value.findIndex(d=>d.code === $item.code); | ||
| if(item){ |
There was a problem hiding this comment.
Can we reduce the complexity of these conditions?
sadhakbj
reviewed
Feb 14, 2022
| } | ||
| }, | ||
| }) | ||
| </script> |
There was a problem hiding this comment.
New empty line at the end of file is highly appreciated
|
help me improve this code, it is perfect to improve the tool |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it is my firts contributed in this project, I am use your project for my job and I contribuyed with us. tranks my number es +34611376019 and my email is jagjerez2015@gmail.com for if your have any cuestion, my english speak is bad.