Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ruby code sample for test (#40) #45

Merged

Conversation

ChandanChainani
Copy link
Contributor

Fixes #40

@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest Hacktoberfest event label Oct 7, 2022
@ChandanChainani
Copy link
Contributor Author

ChandanChainani commented Oct 7, 2022

@JoaoDanielRufino

Few cases which are currently not working for ruby code:

  • line with code and comment together
puts "Welcome to Ruby!"     # prints the welcome message
  • Other form of comment that is allowed in ruby
    =begin
    This is a comment line
    it explains that the next line of code displays
    a welcome message
    =end
    

@JoaoDanielRufino
Copy link
Owner

@JoaoDanielRufino

Few cases which are currently not working for ruby code:

  • line with code and comment together
puts "Welcome to Ruby!"     # prints the welcome message
  • Other form of comment that is allowed in ruby
    =begin
    This is a comment line
    it explains that the next line of code displays
    a welcome message
    =end
    

@ChandanChainani

The line with code and comment together should not be counted as a comment line, so the code is working properly.

The block comment is supported by gcloc, could you add it on the code ? I think you didn't understand my review when I asked for it

Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing contribution!

@JoaoDanielRufino JoaoDanielRufino added the hacktoberfest-accepted Hacktoberfest accepted pull request label Oct 9, 2022
@JoaoDanielRufino JoaoDanielRufino merged commit 28c6467 into JoaoDanielRufino:master Oct 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ruby code sample for tests
2 participants