Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

XML file code sample #63

Merged
merged 3 commits into from
Oct 24, 2022
Merged

XML file code sample #63

merged 3 commits into from
Oct 24, 2022

Conversation

misantron
Copy link
Contributor

Closes #60

JoaoDanielRufino
JoaoDanielRufino requested changes Oct 24, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @misantron, you also need to update tests on scanner_test.go.

Please, take a look at PR #54 for example.

JoaoDanielRufino
JoaoDanielRufino approved these changes Oct 24, 2022
View reviewed changes
Copy link
Owner

@JoaoDanielRufino JoaoDanielRufino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JoaoDanielRufino JoaoDanielRufino added hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request labels Oct 24, 2022
@JoaoDanielRufino JoaoDanielRufino merged commit fa43e91 into JoaoDanielRufino:master Oct 24, 2022
@misantron misantron deleted the xml-file-example branch October 24, 2022 19:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JoaoDanielRufino JoaoDanielRufino JoaoDanielRufino approved these changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest event hacktoberfest-accepted Hacktoberfest accepted pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add XML code sample for tests
2 participants
@misantron @JoaoDanielRufino