Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes missing semicolon in minified plugin. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes missing semicolon in minified plugin. #13

wants to merge 1 commit into from

Conversation

abeisgoat
Copy link

This missing semicolon causes an issue where jQuery may be undefined in the minified version due to the script being ran before your jQuery.js is loaded. This is not an issue in the non-minified version because the semicolon is present. This will probably require a change in your minification configuration to prevent regression :)

@abeisgoat
Copy link
Author

Actually, no. That doesn't solve that, it's an unrelated issue. Should the entire plugin be wrapped in a (function () {...}()) to solve this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant