fix: synchronize the logic of clientLayout to defaultLayout, close #130 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markthree
changed the title
markthree
changed the title
|
OK, Trying to confirm the edge cases here All are fine except one. With vue-router, the I'm not sure there's any way to fix this due to the nature of unplugin-vue-router's structure. Any ideas? I added a simpler example with unplugin-vue-router to test these |
|
I did figure out that it can be fixed with a top-level |
JohnCampionJr
force-pushed
the
fix-130
branch
from
8b034aa to
ca26fcc
Compare
nice |
YunYouJun
reviewed
Dec 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JohnCampionJr
ClientLayout handled issue #130, so I synchronized the logic. If any changes ignore any cases, please let me know