Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed the S3 connection #14233

Merged

Conversation

mehmetbutgul
Copy link
Contributor

The main goal of this PR is to close the connection of s3.

Description

Releases any underlying system resources by invoking the close() method in ResourceDownloader.
There is a bug in spark-nlp==5.3.3, related to #14224
When a lot of models are downloaded;
since the connection is consumed,
"Timeout waiting for connection from pool" error is thrown.

Motivation and Context

There is a bug in spark-nlp==5.3.3. This PR will solve the bug.

How Has This Been Tested?

Locally with Python and Scala.
Additionally, I ran some test code in the Jenkins server when using the jar I created from this branch

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mehmetbutgul mehmetbutgul self-assigned this Apr 11, 2024
@mehmetbutgul mehmetbutgul changed the title closed the connection Closed the S3 connection Apr 11, 2024
@maziyarpanahi maziyarpanahi changed the base branch from master to release/540-release-candidate May 14, 2024 08:51
@maziyarpanahi maziyarpanahi merged commit deb0a45 into release/540-release-candidate May 14, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants