Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Users Top Tracks / Users Top Artists to UserClient #938

Merged
merged 13 commits into from
Jan 19, 2024
Merged

Add Users Top Tracks / Users Top Artists to UserClient #938

merged 13 commits into from
Jan 19, 2024

Conversation

Noelg14
Copy link
Contributor

@Noelg14 Noelg14 commented Jan 18, 2024 •
edited
Loading

Details

Implemented the Get Users Top Items endpoint into the UserClient class.
Link to Spotify Docs

  • Added 2 new Response Types
    • UsersTopTracksResponse
    • UsersTopArtistResponse
  • Added 1 new Request Type
    • UsersTopItemRequest
  • Added Test Cases

@Noelg14 Noelg14 marked this pull request as ready for review January 18, 2024 13:56
@JohnnyCrazy
Copy link
Owner

Hey @Noelg14 ,

Great addition, thank you! :)
I just added two commits, running the formatter and removing the namespace that got probably auto-created because of the file location.

Waiting for the build to pass and then gonna merge this!

@JohnnyCrazy JohnnyCrazy merged commit a27c372 into JohnnyCrazy:master Jan 19, 2024
1 check passed
@WXRIW WXRIW mentioned this pull request Oct 21, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JohnnyCrazy JohnnyCrazy JohnnyCrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noelg14 @JohnnyCrazy