ignore constructor in property expectations (#11)

JonPurvis · Sep 16, 2024 · fef0b37 · fef0b37
1 parent 0cc9ebc
commit fef0b37
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/src/Expectations/Properties.php b/src/Expectations/Properties.php
@@ -22,14 +22,18 @@
     expect(property_exists($this->value, 'tries'))->toBeTrue()
         ->and((new ReflectionClass($this->value)) // @phpstan-ignore-line
             ->getProperty('tries')
-            ->getValue(new $this->value)) // @phpstan-ignore-line
+            ->getValue((new ReflectionClass($this->value))->newInstanceWithoutConstructor())) // @phpstan-ignore-line
         ->toBeGreaterThan(1)
 );
 
 expect()->extend(
     'toHaveRetryInterval',
     fn (): Expectation => // @phpstan-ignore-next-line
     expect(property_exists($this->value, 'retryInterval'))->toBeTrue()
+        ->and((new ReflectionClass($this->value)) // @phpstan-ignore-line
+            ->getProperty('retryInterval')
+            ->getValue((new ReflectionClass($this->value))->newInstanceWithoutConstructor())) // @phpstan-ignore-line
+        ->toBeGreaterThan(0)
 );
 
 expect()->extend(
@@ -38,7 +42,7 @@
     expect(property_exists($this->value, 'useExponentialBackoff'))->toBeTrue()
         ->and((new ReflectionClass($this->value)) // @phpstan-ignore-line
             ->getProperty('useExponentialBackoff')
-            ->getValue(new $this->value)) // @phpstan-ignore-line
+            ->getValue((new ReflectionClass($this->value))->newInstanceWithoutConstructor())) // @phpstan-ignore-line
         ->toBeTrue()
 );
 
@@ -48,6 +52,6 @@
     expect(property_exists($this->value, 'throwOnMaxTries'))->toBeTrue()
         ->and((new ReflectionClass($this->value)) // @phpstan-ignore-line
             ->getProperty('throwOnMaxTries')
-            ->getValue(new $this->value)) // @phpstan-ignore-line
+            ->getValue((new ReflectionClass($this->value))->newInstanceWithoutConstructor())) // @phpstan-ignore-line
         ->toBeTrue()
 );
diff --git a/tests/Fixtures/Arch/ToBeTriedAgainOnFailure/ToBeTriedAgainOnFailure.php b/tests/Fixtures/Arch/ToBeTriedAgainOnFailure/ToBeTriedAgainOnFailure.php
@@ -9,6 +9,10 @@
 
 class ToBeTriedAgainOnFailure extends Request
 {
+    public function __construct(
+        public string $test
+    ) {}
+
     /**
      * Define the HTTP method
      */

diff --git a/tests/Fixtures/Arch/ToHaveRetryInterval/ToHaveRetryInterval.php b/tests/Fixtures/Arch/ToHaveRetryInterval/ToHaveRetryInterval.php
@@ -9,6 +9,10 @@
 
 class ToHaveRetryInterval extends Request
 {
+    public function __construct(
+        public string $test
+    ) {}
+
     /**
      * Define the HTTP method
      */

diff --git a/tests/Fixtures/Arch/ToThrowOnMaxTries/ToThrowOnMaxTries.php b/tests/Fixtures/Arch/ToThrowOnMaxTries/ToThrowOnMaxTries.php
@@ -9,6 +9,10 @@
 
 class ToThrowOnMaxTries extends Request
 {
+    public function __construct(
+        public string $test
+    ) {}
+
     /**
      * Define the HTTP method
      */

diff --git a/tests/Fixtures/Arch/ToUseExponentialBackoff/ToUseExponentialBackoff.php b/tests/Fixtures/Arch/ToUseExponentialBackoff/ToUseExponentialBackoff.php
@@ -9,6 +9,10 @@
 
 class ToUseExponentialBackoff extends Request
 {
+    public function __construct(
+        public string $test
+    ) {}
+
     /**
      * Define the HTTP method
      */