fix: update to support new pyinstaller 5.10 syntax #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#235 pyinstaller/pyinstaller#7560 This adds support for the new pytinstaller > 5.10 syntax for pyi_archive tocs.
|
Thanks @andrewthetechie for the fix! This passed tests locally ( You took care of the leg work of adapting to the new API; I can take care of the rest. CI tests are totally broken right now (#124) anyway. |
|
Glad to help. I use staticx with Pyinstaller to build really small docker images of my python apps https://github.com/andrewthetechie/gha-repo-manager/blob/main/Docker/Dockerfile#L20 |
JonathonReinhart
added a commit
that referenced
this pull request
Apr 16, 2023
Where #236 adapted the new API to the old API with "if pre_510" checks, this takes the opposite approach: Use the new API, and add an adapter class to adapt the old API to the new. Benefits: - No more "if pre_510" checks in the middle of processing code. - Removing the legacy behavior becomes trivial: delete the adapter. Tested: - git clean -fdx test/ - pip install pyinstaller==5.9 - ./test/run_all.sh - pip install pyinstaller==5.10 - ./test/run_all.sh
This was referenced Apr 16, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#235 pyinstaller/pyinstaller#7560
This adds support for the new pyinstaller > 5.10 syntax for pyi_archive tocs.
@JonathonReinhart I tested this locally and it seems to be working and the pytests pass, but I'm not sure how I would add additional unit testing for this code.