staticx: Use importlib.resources over pkg_resources for asset access #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonReinhart
force-pushed
the
266-pkg_resources-again-use-backport
branch
from
0cec14f to
0379caa
Compare
pkg_resources is deprecated: https://setuptools.pypa.io/en/latest/pkg_resources.html This instead uses importlib.resources.files() (introduced in Python 3.9) and uses the backport importlib_resources for Python 3.7-3.8 (to be removed in #264, #265). This was chosen over the alternative of using the deprecated (as of Python 3.11) function importlib.resources.open_binary() (introduced in Python 3.7), since we already have techdebt to remove a related backport, which is preferable to upgrading from the deprecated API.
JonathonReinhart
force-pushed
the
266-pkg_resources-again-use-backport
branch
from
0379caa to
81fa8fe
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
pkg_resources.resource_stream()withimportlib_resources.files().joinpath().open().Fixes #266 (again).