Make disabling joints possible. #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Enhancement
|
I think in this case, I'd use If we're looking for examples of this in Bevy and other ECSs, Flecs has a |
Merged
Jondolf
added a commit
that referenced
this pull request
Dec 9, 2024
# Objective Closes #436. Follow-up to #536. Avian already supports disabling rigid bodies (#536) and joints (#519). The missing piece is disabling colliders! ## Solution Add a `ColliderDisabled` component for temporarily disabling collision detection for colliders and removing them from spatial queries. For now, I decided *not* to prevent disabled colliders from contributing to mass properties of rigid bodies, since the primary purpose of the component is to temporarily disable collision detection, and I think it would be unexpected if it affected the behavior of the rigid body in any other way.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make disabling joints possible.
Solution
I added
DisableJointand added theWithout<DisableJoint>filter on the query.Naming
In discord Jondolf had used the name
JointDisabled; however, I thought the verb formDisableJointwas my preference. But this is not a strong opinion. If there are other past tense components, then I'm happy to have it either way.Other Considerations
I added derives for copy, clone, reflect, and serialize but these were added to follow suit rather than for a good reason of my own.
Alternatives
One could set the compliance to a large number. But what large number? And why bother computing when one would prefer disabling?
Changelog
DisableJointcomponent.