Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use default arch in CI #162

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Use default arch in CI #162

merged 3 commits into from
Dec 2, 2024

Conversation

JoshuaLampert
Copy link
Owner

@JoshuaLampert JoshuaLampert commented Dec 2, 2024

There are warnings (e.g., https://github.com/JoshuaLampert/DispersiveShallowWater.jl/actions/runs/12108289323) in the CI runs because we request x64 on a macOS runner with arm64. I propose to simply use the default architecture, i.e. to remove the arch argument. For the flag-name of the coveralls action I followed the example under https://github.com/coverallsapp/github-action?tab=readme-ov-file#complete-parallel-job-example.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (fe7c569) to head (0b98ad6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          19       19           
  Lines        1776     1776           
=======================================
  Hits         1740     1740           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Benchmark Results

main 0b98ad6... main/0b98ad6587eeef...
bbm_1d/bbm_1d_basic.jl 14.3 ± 0.48 μs 13.6 ± 0.33 μs 1.05
bbm_1d/bbm_1d_fourier.jl 0.527 ± 0.0038 ms 0.527 ± 0.0027 ms 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl 0.115 ± 0.0032 ms 0.113 ± 0.002 ms 1.01
bbm_bbm_1d/bbm_bbm_1d_dg.jl 0.0342 ± 0.00049 ms 0.0341 ± 0.00041 ms 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl 27.3 ± 0.47 μs 27.4 ± 0.48 μs 0.999
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl 0.0484 ± 0.00049 ms 0.0483 ± 0.00046 ms 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl 4.11 ± 0.014 μs 4.16 ± 0.013 μs 0.988
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl 0.198 ± 0.0052 ms 0.197 ± 0.0049 ms 1.01
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl 0.148 ± 0.0028 ms 0.146 ± 0.0022 ms 1.01
time_to_load 1.99 ± 0.0011 s 1.98 ± 0.0065 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Benchmark Plot

@JoshuaLampert
Copy link
Owner Author

So it seems CI uses another Mac machine now, which allocates a bit more for one test and needs some adjusted tolerances.

@JoshuaLampert JoshuaLampert requested a review from ranocha December 2, 2024 15:19
Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoshuaLampert JoshuaLampert merged commit 7db41d9 into main Dec 2, 2024
18 checks passed
@JoshuaLampert JoshuaLampert deleted the arch-ci branch December 2, 2024 15:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants