-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use default arch
in CI
#162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 19 19
Lines 1776 1776
=======================================
Hits 1740 1740
Misses 36 36 ☔ View full report in Codecov by Sentry. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
So it seems CI uses another Mac machine now, which allocates a bit more for one test and needs some adjusted tolerances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There are warnings (e.g., https://github.com/JoshuaLampert/DispersiveShallowWater.jl/actions/runs/12108289323) in the CI runs because we request x64 on a macOS runner with arm64. I propose to simply use the default architecture, i.e. to remove the
arch
argument. For theflag-name
of the coveralls action I followed the example under https://github.com/coverallsapp/github-action?tab=readme-ov-file#complete-parallel-job-example.