Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix doctests #153

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Fix doctests #153

merged 3 commits into from
Dec 11, 2018

Conversation

c42f
Copy link
Member

@c42f c42f commented Dec 11, 2018

The documentation build and doctests currently fail, breaking CI. Fix this:

  • Add sitename property now required by Documenter
  • Fix use of Base.summary so that axis type information is readable again.
  • Update doctest outputs to the numbers produced in julia 1.0, and the latest version of Unitful.
  • Move forward with docs deploy via julia 1.0

Chris Foster added 2 commits December 11, 2018 12:44
Base now uses the io-based version of summary, so all axis array type
summary info was broken in 1.0.
* Add sitename property now required by Documenter

* Update doctest outputs to the numbers produced in julia 1.0, and the
  latest version of Unitful.

* Move forward with docs deploy via julia 1.0
@c42f
Copy link
Member Author

c42f commented Dec 11, 2018

Coveralls seems terribly confused (it thinks this PR reduces coverage from 100% down to 75%). Presumably that's due to coverage data being submitted by all builds (+ some changes to the way coverage is measured on nightly), so I've pushed 99cfef9 in an attempt to mitigate that.

@timholy timholy merged commit 650cca9 into master Dec 11, 2018
@c42f c42f deleted the cjf/fix-doctests branch December 12, 2018 00:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants