Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow findfirst(isone) and findfirst(iszero) for InfRanges #179

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

DanielVandH
Copy link
Contributor

@DanielVandH DanielVandH commented Jun 17, 2024

Fixes #178

Also changes my previous PR #177 to use the new findfirst(iszero)

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (d6eaad4) to head (c4c2b74).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   86.00%   85.14%   -0.86%     
==========================================
  Files           6        6              
  Lines         743      754      +11     
==========================================
+ Hits          639      642       +3     
- Misses        104      112       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH
Copy link
Contributor Author

DanielVandH commented Jun 17, 2024

This doesn't work for reversed ranges..

findfirst(==(1), 10:-1:-∞) # should be 10?

Should it? Probably it's own issue since this issue already exists on master #180

@dlfivefifty dlfivefifty merged commit c45ae5f into JuliaArrays:master Jun 25, 2024
8 of 9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iszero/isone aren't efficient on InfRanges
2 participants