Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Grant permissions to docs workflow #591

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Grant permissions to docs workflow #591

merged 1 commit into from
Nov 17, 2024

Conversation

wheeheee
Copy link
Member

Switch from using DOCUMENTER_KEY, following example in https://github.com/julia-actions/julia-docdeploy.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (a98e64f) to head (48e6f26).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #591   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          19       19           
  Lines        3249     3249           
=======================================
  Hits         3179     3179           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wheeheee wheeheee merged commit b854a65 into master Nov 17, 2024
11 checks passed
@wheeheee wheeheee deleted the doc_perm branch November 17, 2024 05:03
@martinholters
Copy link
Member

Shouldn't the permissions also include pull-requests: read?

@wheeheee
Copy link
Member Author

Seems like it isn't required, the example in the link above doesn't have it. Maybe read permissions are granted by default.

@martinholters
Copy link
Member

Hm, indeed looks like it isn't needed, although https://documenter.juliadocs.org/stable/man/hosting/#Permissions indicates otherwise.

@wheeheee wheeheee added the no changelog Prevent TagBot from inclusion in release notes label Nov 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no changelog Prevent TagBot from inclusion in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants