Add DataAPI.unwrap with default definition #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 90.90% 91.30% +0.39%
==========================================
Files 1 1
Lines 22 23 +1
==========================================
+ Hits 20 21 +1
Misses 2 2
Continue to review full report at Codecov.
|
|
Thank you. Could you also bump a version of DataAPI.jl so that we could register it after merging? Thank you. |
bkamins
approved these changes
Feb 14, 2021
nalimilan
reviewed
Feb 14, 2021
| @@ -85,4 +85,9 @@ end | |||
|
|
|||
| end | |||
|
|
|||
| @testset "unwrap" begin | |||
| @test DataAPI.unwrap(1) === 1 | |||
| @test DataAPI.unwrap(missing) === missing | |||
There was a problem hiding this comment.
Ah, clever: with that fallback we don't need to use passmissing(unwrap)!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in
JuliaData/CategoricalArrays.jl#142.