Remove special cases for AbstractFiniteDifference
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Completely missed that of course in finite differencing the differentiated function might be called the first time with different inputs - and that this is the reason for the FiniteDifference branches, not the bug in FiniteDifferences. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #2, it seems the special cases for
AbstractFiniteDifferenceonly exist because FiniteDifferences mutated the inputs in previous releases (also, the checks don't seem completely consistent). This FiniteDifference behaviour was a bug and fixed in version 0.12.28 (JuliaDiff/FiniteDifferences.jl#223).This PR removes the special cases and checks if tests pass with the latest FiniteDifferences release.