Default to the older behavior #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 86.82% 86.23% -0.60%
==========================================
Files 22 22
Lines 1283 1293 +10
==========================================
+ Hits 1114 1115 +1
- Misses 169 178 +9 ☔ View full report in Codecov by Sentry. |
avik-pal
changed the title
p if it is NullParameters
|
Failures expected here. Fixed by SciML/OrdinaryDiffEq.jl#2062 and SciML/NonlinearSolve.jl#285. Once this and SciML/SciMLBase.jl#543 are merged we can trigger those 2 CIs to confirm that things worked out |
|
@ChrisRackauckas this can be merged |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.