Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ZygoteRules -> ChainRules (2) #237

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

ZygoteRules -> ChainRules (2) #237

wants to merge 14 commits into from

Conversation

MasonProtter
Copy link
Member

This is just #232 except I fixed up the whole Run.jl situation by updating the environments. I dropped julia versions pre-1.6 because it's not worth the CI time or hassle supporting something that's not even LTS.

Sorry @ToucheSir, I couldn't figure out how to push these changes to your branch so I just did this.

@MasonProtter
Copy link
Member Author

I might just remove the benchmark script. Sounds useful to have, but I don't know how to maintain it.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #237 (c27c744) into master (d70a19b) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   91.52%   91.80%   +0.28%     
==========================================
  Files          23       23              
  Lines         531      537       +6     
==========================================
+ Hits          486      493       +7     
+ Misses         45       44       -1     
Flag Coverage Δ
unittests 91.80% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/BangBang.jl 100.00% <ø> (ø)
src/chainrules.jl 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants