Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix testing #80

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Fix testing #80

merged 3 commits into from
Feb 4, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Feb 4, 2022

Those tests once marked broken (#60) seem to pass now.

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #80 (9b1f348) into master (67a2368) will decrease coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   64.42%   63.90%   -0.52%     
==========================================
  Files           5        4       -1     
  Lines         208      266      +58     
==========================================
+ Hits          134      170      +36     
- Misses         74       96      +22     
Impacted Files Coverage Δ
src/perspective.jl 75.00% <ø> (+5.00%) ⬆️
src/affine.jl 48.10% <0.00%> (-4.84%) ⬇️
src/core.jl 37.83% <0.00%> (-0.10%) ⬇️
src/CoordinateTransformations.jl
src/coordinatesystems.jl 78.98% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a3f90...9b1f348. Read the comment docs.

@c42f
Copy link
Member

c42f commented Feb 4, 2022

Thanks, I've added a tweak here to ensure we run CI on more recent Julia versions too. Let's merge if that passes, I guess.

@c42f c42f merged commit 78f5a5c into JuliaGeometry:master Feb 4, 2022
@t-bltg t-bltg deleted the testing branch February 4, 2022 21:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants