Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix circular dependencies #65

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

dgleich
Copy link
Contributor

@dgleich dgleich commented Oct 31, 2024

If you have two dependencies with the same prerequisite, there is a circular loop created in the dependency loading graph.

See discussion here:

I believe this will fix #56

@dgleich
Copy link
Contributor Author

dgleich commented Oct 31, 2024

@gdalle if you can take a look (there may be other small pull requests too... that could be merged to tag a release...) Currently GraphIO and EzXML throw some annoying errors on Julia 1.10 and 1.11 relating to the 'circular' stuff in the extensions.

@gdalle
Copy link
Member

gdalle commented Nov 6, 2024

Thanks for the contribution! This PR should probably also remove the existing extension files?

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gdalle gdalle merged commit 9d32f65 into JuliaGraphs:master Nov 6, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompilation error with ParserCombinator
2 participants