Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added a better Default for GetPatientAgeGroup #75

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Added a better Default for GetPatientAgeGroup #75

merged 2 commits into from
Feb 21, 2024

Conversation

Jay-sanjay
Copy link
Member

This PR addresses #73

closes #73

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac5bcf0) 74.51% compared to head (fb9cfd8) 74.51%.
Report is 75 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #75   +/-   ##
=======================================
  Coverage   74.51%   74.51%           
=======================================
  Files           6        6           
  Lines         310      310           
=======================================
  Hits          231      231           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheCedarPrince TheCedarPrince changed the base branch from main to dev February 21, 2024 23:13
@TheCedarPrince
Copy link
Member

So, for some reason, this is now failing on nightly. I am fairly certain this is a result of something happening in nightly and may end up submitting a bug to Julia itself. Otherwise, I am going to accept this PR. Thanks @Jay-sanjay

@TheCedarPrince TheCedarPrince merged commit 824afbe into dev Feb 21, 2024
18 of 24 checks passed
@TheCedarPrince TheCedarPrince deleted the unspec branch February 21, 2024 23:51
@TheCedarPrince
Copy link
Member

@Jay-sanjay -- fun fact, your work here found a bug in a future version on Julia! JuliaLang/julia#53425 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make a Better Default for GetPatientAgeGroup
2 participants