Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Commit

Permalink
Merge pull request #112 from Seelengrab/deprecation_using
Browse files Browse the repository at this point in the history
Add deprecation notice on `using`
  • Loading branch information
kescobo authored Feb 26, 2024
2 parents 381dd35 + 5888010 commit 9ebb21c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
4 changes: 3 additions & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
name = "Formatting"
uuid = "59287772-0a20-5a39-b81b-1366585eb4c0"
version = "0.4.2"
version = "0.4.3"

[deps]
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"

[compat]
Logging = "1"
julia = "1"

[extras]
Expand Down
18 changes: 17 additions & 1 deletion src/Formatting.jl
Original file line number Diff line number Diff line change
@@ -1,13 +1,29 @@
module Formatting

import Base.show
using Printf
using Printf, Logging

export
FormatSpec, FormatExpr,
printfmt, printfmtln, fmt, format,
sprintf1, generate_formatter

if ccall(:jl_generating_output, Cint, ()) == 1
@warn """
DEPRECATION NOTICE
Formatting.jl has been unmaintained for a while, with some serious
correctness bugs compromising the original purpose of the package. As a result,
it has been deprecated - consider using an alternative, such as
`Format.jl` (https://github.com/JuliaString/Format.jl) or the `Printf` stdlib directly.
If you are not using Formatting.jl as a direct dependency, please consider
opening an issue on any packages you are using that do use it as a dependency.
From Julia 1.9 onwards, you can query `]why Formatting` to figure out which
package originally brings it in as a dependency.
"""
end

include("cformat.jl" )
include("fmtspec.jl")
include("fmtcore.jl")
Expand Down

4 comments on commit 9ebb21c

@kescobo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Register Failed
@kescobo, it looks like you are not a publicly listed member/owner in the parent organization (JuliaIO).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@kescobo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/101727

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.3 -m "<description of version>" 9ebb21c86d130dde04955e33e22506200c60272e
git push origin v0.4.3

Please # to comment.