Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CompatHelper: bump compat for "AxisArrays" to "0.4" #43

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2020

This pull request changes the compat entry for the AxisArrays package from 0.3 to 0.3, 0.4.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Jan 1, 2020

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files           1        1           
  Lines         133      133           
=======================================
  Hits          106      106           
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b16696...a372c97. Read the comment docs.

@johnnychen94
Copy link
Member

johnnychen94 commented Jan 1, 2020

Personal opinion: since AxisArrays v0.4 doesn't contain any new features, we could choose to not bump a patch release immediately.

@johnnychen94 johnnychen94 merged commit e110059 into master Jan 1, 2020
@johnnychen94 johnnychen94 deleted the compathelper/new_version/2020-01-01-00-21-34-964-1226538341 branch January 1, 2020 03:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant