Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Project file to docs #47

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Add Project file to docs #47

merged 4 commits into from
Feb 12, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 12, 2020

Closes #46

@johnnychen94
Copy link
Member

Is the version bump only to deploy updated documentation?

@timholy
Copy link
Member Author

timholy commented Feb 12, 2020

Yes, that's the idea. I guess we could also delete & re-push tags. Would you prefer that?

@johnnychen94
Copy link
Member

johnnychen94 commented Feb 12, 2020

I guess we could also delete & re-push tags. Would you prefer that?

This looks better to me since we haven't introduced anything new so far.

@timholy
Copy link
Member Author

timholy commented Feb 12, 2020

We'll probably lose the nice tag written by TagBot. It will just be 0.6.3 with no further detail. Still worth it?

@johnnychen94
Copy link
Member

johnnychen94 commented Feb 12, 2020

I'd just copy & past 😄 (e.g, from Images.jl to juliaimages.github.io)

Well, tag a new release might be the easiest way without messing things up.

@timholy
Copy link
Member Author

timholy commented Feb 12, 2020

FYI, for coverage nightly will be best due to JuliaLang/julia#34254

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files           1        1           
  Lines         124      124           
=======================================
  Hits           86       86           
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e178884...f18d259. Read the comment docs.

@johnnychen94 johnnychen94 merged commit e75e34c into master Feb 12, 2020
@johnnychen94 johnnychen94 deleted the teh/docs branch February 12, 2020 20:22
@timholy
Copy link
Member Author

timholy commented Feb 12, 2020

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs to set documenter key
2 participants