Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

permuteddimsview -> PermutedDimsArray #50

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

vtjeng
Copy link
Contributor

@vtjeng vtjeng commented Sep 27, 2020

Before Change

On a Jupyter notebook with Julia 1.4.2, Images v0.22.4 (specifically with ImageAxes v0.6.5 and ImageMetadata v0.9.2):

using Images

┌ Info: Precompiling Images [916415d5-f1e6-5110-898d-aaa5f9f070e0]
└ @ Base loading.jl:1260
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/ImageAxes/ppqC3/src/ImageAxes.jl:114
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/ImageMetadata/Ss1Hl/src/ImageMetadata.jl:243
x= rand(1, 40, 40, 1)
colorview(Gray, x[1, :, :, 1])

┌ Info: Precompiling PNGFiles [f57f5aa1-a3ce-4bc8-8ab9-96f992907883]
└ @ Base loading.jl:1260
┌ Info: Precompiling ImageMagick [6218d12a-5da1-5696-b52f-db25d2ecc6d1]
└ @ Base loading.jl:1260

WARNING: importing deprecated binding ImageCore.permuteddimsview into ImageAxes.
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: importing deprecated binding ImageCore.permuteddimsview into ImageMetadata.
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52
WARNING: ImageCore.permuteddimsview is deprecated, use PermutedDimsArray instead.
  likely near /home/vtjeng/.julia/packages/IJulia/tOM8L/src/kernel.jl:52

After Change

Combined with JuliaImages/ImageMetadata.jl#69

using Images

┌ Info: Precompiling Images [916415d5-f1e6-5110-898d-aaa5f9f070e0]
└ @ Base loading.jl:1260

x= rand(1, 40, 40, 1)
colorview(Gray, x[1, :, :, 1])

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files           1        1           
  Lines         124      124           
=======================================
  Hits           89       89           
  Misses         35       35           
Impacted Files Coverage Δ
src/ImageAxes.jl 71.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0828f0f...ceabad0. Read the comment docs.

@johnnychen94 johnnychen94 merged commit e839041 into JuliaImages:master Sep 27, 2020
@vtjeng vtjeng deleted the fix-deprecated-function branch September 27, 2020 18:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants