Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug/move std to cvs #879

Closed
wants to merge 5 commits into from
Closed

Conversation

wizofe
Copy link

@wizofe wizofe commented Mar 7, 2020

Remove std, mean and complement and migrate to ColorVectorSpace.jl including tests.

closes #872
closes #698

@johnnychen94
Copy link
Member

Thanks! Looks like exposure.jl needs to be removed as well (don't forget to remove the line include("exposure.jl") in Images.jl)

The test here fails because JuliaGraphics/ColorVectorSpace.jl#125 isn't merged yet. Retrigger the test after a new release in ColorVectorSpaces should give it a green check

@wizofe
Copy link
Author

wizofe commented Mar 9, 2020

Thank you @johnnychen94 for your review. I did both changes and hopefully the tests will go through after merging as you predicted :)

Indeed I removed exposures.jl earlier but I forgot to push. Leaving this open now and moving my efforts to the other PR.

@johnnychen94
Copy link
Member

Leaving this open now and moving my efforts to the other PR.

Sure, as you might already notice, the step 1 doesn't go very smoothly and more discussion is needed there. But for this PR I think it's ready.

Doing things parallelly is definite one most common thing in open-source would because most people don't do it as a full-time job and might not respond very quickly.

Looking forward to your next PR!

@kimikage
Copy link

kimikage commented Mar 4, 2021

JuliaGraphics/ColorVectorSpace.jl#125 was closed, and JuliaGraphics/ColorVectorSpace.jl#144 was merged.

Therefore, we need to limit the lower bound of [compat] (of ImageCore?) or add a hasmethod check to prevent redefinition of complement.

cc: @johnnychen94, @timholy

@johnnychen94 johnnychen94 mentioned this pull request Aug 3, 2021
4 tasks
@johnnychen94 johnnychen94 added this to the v0.25 milestone Oct 30, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move var, std to ColorVectorSpace Shouldn't complement live in Colors.jl?
3 participants