-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bug/move std to cvs #879
Bug/move std to cvs #879
Conversation
Thanks! Looks like exposure.jl needs to be removed as well (don't forget to remove the line The test here fails because JuliaGraphics/ColorVectorSpace.jl#125 isn't merged yet. Retrigger the test after a new release in ColorVectorSpaces should give it a green check |
Thank you @johnnychen94 for your review. I did both changes and hopefully the tests will go through after merging as you predicted :) Indeed I removed |
Sure, as you might already notice, the step 1 doesn't go very smoothly and more discussion is needed there. But for this PR I think it's ready. Doing things parallelly is definite one most common thing in open-source would because most people don't do it as a full-time job and might not respond very quickly. Looking forward to your next PR! |
JuliaGraphics/ColorVectorSpace.jl#125 was closed, and JuliaGraphics/ColorVectorSpace.jl#144 was merged. Therefore, we need to limit the lower bound of cc: @johnnychen94, @timholy |
Remove std, mean and complement and migrate to
ColorVectorSpace.jl
including tests.closes #872
closes #698