Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CompatHelper: bump compat for "ImageCore" to "0.9" (redo #954) #957

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

johnnychen94
Copy link
Member

For compatibility issues, I've revert #954 in #956. With the patch version Images v0.24.1 released, we can now cherry-pick it back and continue the normal devs.

* CompatHelper: bump compat for "ImageCore" to "0.9"

* require ImageCore 0.9

- remove direct dependency to CVS
- remove useless compat codes for RGB1->XRGB deprecations

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@johnnychen94 johnnychen94 changed the title CompatHelper: bump compat for "ImageCore" to "0.9" (#954) CompatHelper: bump compat for "ImageCore" to "0.9" (redo #954) Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #957 (ce28100) into master (bff89d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #957   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files           9        9           
  Lines        1026     1026           
=======================================
  Hits          882      882           
  Misses        144      144           
Impacted Files Coverage Δ
src/Images.jl 14.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff89d1...ce28100. Read the comment docs.

@johnnychen94 johnnychen94 merged commit 9e782af into master Apr 27, 2021
@johnnychen94 johnnychen94 deleted the jc/ic09 branch April 27, 2021 07:56
@johnnychen94 johnnychen94 mentioned this pull request Jul 28, 2021
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant