Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

First try of removing failed decls, not working at all #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tehrengruber
Copy link

This is a first try of removing failed decls, but its not working at all. The cases that I thought would be working weren't since no error was emitted...
After a Decl of a Function was removed they still dangle arround in the Lookup tables (so lookup_name will return an invalid decl). Additionally I probably need to remove them from their Scope. To do this correctly we need something like a DeclRemovalVisitor, which would become very similar to how cling does its Transaction rewind stuff (https://github.com/vgvassilev/cling/blob/master/lib/Interpreter/TransactionUnloader.cpp). It's probably possible to adopt a lot of their code by just stripping out the Transaction stuff (which might not be a good idea since their code might not be totally stable yet and we might want transaction rewinding at a later point).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant