Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolve compat issues for m1 macs #294

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Conversation

iliailmer
Copy link
Contributor

Resolves to #293

Signed-off-by: Ilia <i.ilmer@icloud.com>
@lbenet
Copy link
Member

lbenet commented Feb 3, 2023

Thanks for spotting the problems and open this PR.

I just run the tests, and there are problems apparently due to requirements from TaylorModels.jl with Julia version 1.5 (see https://github.com/JuliaIntervals/ValidatedNumerics.jl/actions/runs/4078312446/jobs/7046642429#step:5:29). Could you increase the Julia version required to Julia 1.6, as well as the tests, which should not consider Julia v1.5? We should also tag a new minor version?

Signed-off-by: Ilia <i.ilmer@icloud.com>
@iliailmer
Copy link
Contributor Author

@lbenet I added the versions to CI.yml and Project.toml, should work now.

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll go ahead and merge this, and also register the new version. Thanks a lot!

@lbenet lbenet merged commit 67ce816 into JuliaIntervals:master Feb 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants