Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original versions of
read(s::GZipStream, ::Type{Char})
andwrite(s::GZipStream, Char)
in #1355, Jeff suggested generalizing the functions so they work with all IO streams.Edit: removed error message, fixed by Jameson's comment below.
Edit: The read and write methods above work, but don't quite go far enough. So, additionally, this patch
The bytestring(io::IOString) method isn't (yet) a replacement for memio(), since it copies the data. This is actually necessary, currently, because utf8 string written to IOString are converted to disk format (cf. the original read/write functions above). It may be worthwhile NOT to do so for IOString.