logging: redirect closed streams to stderr/stdout #40423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the additional benefit of making the initial logger respect changes to redirect_stderr/stdout, until the user explicitly sets another stream as the logging destination. Fix #26798 Fix #38482 Replaces #26920, which provided the idea and most of the implementation Co-authored-by: Joe Petviashvili <joe@gnom.us>
|
Bump. I'll give this a few more days for reviewers to respond |
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
This has the additional benefit of making the initial logger respect changes to redirect_stderr/stdout, until the user explicitly sets another stream as the logging destination. Fix JuliaLang#26798 Fix JuliaLang#38482 Replaces JuliaLang#26920, which provided the idea and most of the implementation Co-authored-by: Joe Petviashvili <joe@gnom.us>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
This has the additional benefit of making the initial logger respect changes to redirect_stderr/stdout, until the user explicitly sets another stream as the logging destination. Fix JuliaLang#26798 Fix JuliaLang#38482 Replaces JuliaLang#26920, which provided the idea and most of the implementation Co-authored-by: Joe Petviashvili <joe@gnom.us>
4 tasks
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This has the additional benefit of making the initial logger respect changes to redirect_stderr/stdout, until the user explicitly sets another stream as the logging destination. Fix JuliaLang#26798 Fix JuliaLang#38482 Replaces JuliaLang#26920, which provided the idea and most of the implementation Co-authored-by: Joe Petviashvili <joe@gnom.us>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the additional benefit of making the initial logger respect
changes to redirect_stderr/stdout, until the user explicitly sets
another stream as the logging destination.
Fix #26798
Fix #38482
Replaces #26920, which provided the idea and most of the implementation
Co-authored-by: @GAIKA Thanks for this initial work to make this happen! Sorry it took so long to review.