Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Base.close for TBLogger #109

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Add Base.close for TBLogger #109

merged 3 commits into from
Mar 15, 2022

Conversation

darsnack
Copy link
Contributor

@darsnack darsnack commented Mar 9, 2022 •
edited
Loading

Fixes #108

@PhilipVinc
Copy link
Member

should we maybe add a finaliser to TBLogger that calls close?

@darsnack
Copy link
Contributor Author

darsnack commented Mar 9, 2022

Good idea, just added it.

@darsnack
Copy link
Contributor Author

@PhilipVinc I think this is good now?

@PhilipVinc
Copy link
Member

looks great! thanks

@PhilipVinc PhilipVinc merged commit 9206147 into JuliaLogging:master Mar 15, 2022
@MilesCranmer MilesCranmer mentioned this pull request Dec 4, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@PhilipVinc PhilipVinc PhilipVinc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Base.close?
2 participants
@darsnack @PhilipVinc