Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests bug fix + JET quality & type stability check #40

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

algunion
Copy link
Contributor

@algunion algunion commented Jul 3, 2023

The completion test was broken. The main reason for that was that the model used was retrieved by r.response["data"][begin]["id"], which is not guaranteed always to return a model that is compatible with the completion endpoint (these days it returns the whisper-1 model). The test completion test is using text-ada-001 model now.

Other changes:

  • created a separate test file for chat completion: despite the naming similarity, the /v1/chat/completions has nothing to do with /v1/completions. If a test fails, we need to be able to differentiate between the two easily.
  • added JET code quality test - this check will work as a helpful additional QA layer

@algunion
Copy link
Contributor Author

algunion commented Jul 3, 2023

Just wanted to trigger the tests again - after adding the OPENAI_API_KEY variable to the repo.

@algunion
Copy link
Contributor Author

algunion commented Jul 3, 2023

The CI/test still fails to use the env key. Local tests passed.

If a different configuration is needed and you can point me out to that, please let me know, and I'll add that.

This is my current settings:
.......................................................
repo env key

@algunion algunion changed the title tests bug fix + JET quality check tests bug fix + JET quality & type stability check Jul 6, 2023
@roryl23 roryl23 merged commit c12ae68 into JuliaML:main Jul 8, 2023
@roryl23
Copy link
Collaborator

roryl23 commented Jul 8, 2023

I'm not entirely sure what the problem is with CI tests in GitHub actions, I'll look at it this weekend

@algunion algunion deleted the testsplit branch July 8, 2023 19:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants